Fix for STI scoping across leaves #16775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
d-m-u
changed the title
|
@Fryguy I think this's what you wanted. |
|
@d-m-u I think you could probably DRY up all the |
d-m-u
changed the title
d-m-u
force-pushed
the
issue_16739
branch
2 times, most recently
from
c0f4a9e
to
e948ab2
Compare
d-m-u
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
bdunne
requested changes
Jan 12, 2018
|
This pull request is not mergeable. Please rebase and repush. |
|
@d-m-u Please rebase |
|
Checked commit d-m-u@ad0f581 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Jan 15, 2018
|
Adding gaprindashvili/yes since this is needed to backport #17544 to gaprindashvili |
simaishi
pushed a commit
that referenced
this pull request
Jun 14, 2018
Fix for STI scoping across leaves (cherry picked from commit c992bac)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a concern that classes using STI do not work with the unique_within_region validation (that currently uses record.class). The validation may not properly scope across leaf classes. The suggestion was to use record.class.base_class instead.
😭
per #16739